Doctrine Project

[DDC-2199] Yaml driver does not take into account field @Version attribute

Sun, 16 Dec 2012 12:01:03 +0000

Even if field has version: true attribute, Yaml driver does not set class metadata isVersioned and versionField properties. As a result optimistic lock cannot be used.

[DDC-2211] [GH-541] Fix DDC-1690

Sat, 22 Dec 2012 11:48:27 +0000

This issue is created automatically through a Github pull request on behalf of PSchwisow:

Url: https://github.com/doctrine/doctrine2/pull/541

Message:

Added the lines suggested by the original reporter.

[DDC-2206] Setup::registerAutoloadPEAR and registerAutoloadDirectory load Symfony\Componet namespace path through pear is wrong

Sun, 23 Dec 2012 19:35:38 +0000

install doctrine use pear,and the installed path is get_include_path()/Doctrine,get_include_path()/Symfony,but now Symfony\Component namespace path direct to get_include_path()/doctrine,so some file issue

[DDC-2192] Version field not honored by XML driver

Sun, 16 Dec 2012 12:01:16 +0000

When specifying a version field in an XML mapping file, it is never picked up by the XML mapping driver and given to ClassMetadataInfo::setVersionMapping()

[DDC-2175] Optimistic locking version not refreshed on update for class table inheritance

Mon, 24 Dec 2012 10:20:10 +0000

I am trying to use optimistic locking with class table inheritance. I put the version column in the base table. When I perform change a base entity value, persist, and flush, the version in memory does not update to match the new version in the base table. Consequently, subsequent updates fail with "The optimistic lock on an entity failed."

As far as I can tell, the reason is that the update method in Doctrine/ORM/Persisters/JoinedSubclassPersister.php does not call assignDefaultVersionValue in this case.

This change appears to fix the problem.

--- a/lib/Doctrine/ORM/Persisters/JoinedSubclassPersister.php
+++ b/lib/Doctrine/ORM/Persisters/JoinedSubclassPersister.php
@@ -227,9 +227,10 @@ class JoinedSubclassPersister extends AbstractEntityInheritancePersister
 
             // Make sure the table with the version column is updated even if no columns on that
             // table were affected.
-            if ($isVersioned && ! isset($updateData[$versionedTable])) {
-                $this->_updateTable($entity, $this->quoteStrategy->getTableName($versionedClass, $this->_platform), array(), true);
-
+            if ($isVersioned) {
+                if (! isset($updateData[$versionedTable])) {
+                    $this->_updateTable($entity, $this->quoteStrategy->getTableName($versionedClass, $this->_platform), array(), true);
+                }
                 $id = $this->_em->getUnitOfWork()->getEntityIdentifier($entity);
                 $this->assignDefaultVersionValue($entity, $id);
             }

The new code then looks like this:

            // Make sure the table with the version column is updated even if no columns on that
            // table were affected.
            if ($isVersioned) {
                if (! isset($updateData[$versionedTable])) {
                    $this->_updateTable($entity, $this->quoteStrategy->getTableName($versionedClass, $this->_platform), array(), true);
                }   
                $id = $this->_em->getUnitOfWork()->getEntityIdentifier($entity);
                $this->assignDefaultVersionValue($entity, $id);
            }

[DDC-1690] Notify policy listeners are not attached to entities with Notify policy

Sat, 22 Dec 2012 11:48:43 +0000

It seems that it happens because the UnitOfWork::addToIdentityMap() is not the only way to add an entity to the identity map. It is possible to do it directly by assigning array values (pulling my hair why?) . But the code in that method also adds a property changed listener to an entity. As a result that entity is not persisted properly as it does not have a listener. I spent a lot of time trying to figure out why some of my entities were persisted and others no. That happens for entities of same class with parent - children associations.

Probably the notify policy is not very popular otherwise the bug would have been reported long time ago.

Adding these lines to the UnitOfWork at line 2004 fixes the issue:

    // PERF: Inlined & optimized code from UnitOfWork#registerManaged()
    $newValueOid = spl_object_hash($newValue);
    $this->entityIdentifiers[$newValueOid] = $associatedId;
    $this->identityMap[$targetClass->rootEntityName][$relatedIdHash] = $newValue;
    // new lines
 -- if ($newValue instanceof NotifyPropertyChanged) {
 --     $newValue->addPropertyChangedListener($this);
 -- }
    //end of new lines
    $this->entityStates[$newValueOid] = self::STATE_MANAGED;
    // make sure that when an proxy is then finally loaded, $this->originalEntityData is set also!