Pull request with a potential fix: https://github.com/doctrine/doctrine2/pull/429

Assigned to Guilherme

Is `$copy = clone $queryBuilder();` a typo?

Sorry, this is a typo, was meant: $copy = clone $queryBuilder;

This is being handled at DDC-1936 (https://github.com/doctrine/doctrine2/pull/404)

Hi. Thanks for the quick response.

I looked at the changes, and have a question: whether you need to reset the parameters when cloning? Thus broken backward compatibility with versions <2.3.

Actually, I just implemented your expected behaviour (see tests), which is compatible with what the `AbstractQuery` does. It can also be done the other way around, waiting for feedback by Benjamin Eberlei

Ah, nevermind. You're right. Will change my code

MySQL

Can you try using the quoting strategy in master? By defining an '@Table(name="`Group`")' on your entity you should be able to fix this issue by yourself... Anyway, this is only available in latest master.
Please give it a try and let us know.

That hack, of course, fixes the problem. However, Doctrine is failing to escape entities with reserved keywords in various different situations and this should be a major problem, specially since there are many keywords that are common table names. Having to change the table name or escape the table name manually is not the best solution.

I have look through the code but could not find out why getQuotedTableName() is failing to quote the table name "Group". I fixed the other problem, involving schema creation, but this one i couldn't fix. That's why i'm opening the issue, hoping someone with more experience in the ORM codebase manages to fix it.

Klaus Silveira, doctrine won't quote (at least with the default strategy) a table called "Group". The default strategy will look for the sorrounding "`" ("`Group`").
Is it still failing to quote something in latest master? Can you write a simple example of a failure you are getting?

The failure is caused when querying anything related to an entity wich it's name is a reserved keyword, for example, an entity called "Group". I expected Doctrine to quote such table names.

Klaus Silveira did you put an @Table(name="`Group`") in it?

Please note that

@Table(name="Group")

and

@Table(name="`Group`")

are quite different. That's why I'm asking

As i said, that hack fixes the problem. But i don't believe that having to change the table name or escape the table name manually is the best solution. Doctrine should be doing that transparently, as it does for other situations (such as during schema creation). Why not during all other operations? Makes no sense at all.

This is not a hack... In ORM, "`" is not the MySQL identifier quote. It is exactly thought as a character with which you tell the ORM that the identifier should be quoted.
The default strategy does make use of it, so please use it.

Also, we won't collect the SQL reserved keywords, nor we can know what keywords are used in all vendors. The patch for the quoting strategy was exactly thought to allow end users to use insecure names for their objects/fields/indexes/etc but without having the ORM implement those checks for them (since it would just be messy and too "magic").

Please also reconsider your pull request on github too ( DBAL-298 ).

I'm closing this one

Then what's the purpose of Doctrine\DBAL\Platforms\Keywords\MySQLKeywords?

Klaus Silveira not sure, but it isn't used in ORM.

A related Github Pull-Request [GH-166] was closed
https://github.com/doctrine/dbal/pull/166

Mac OSX MAMP (apache + php 5.3.6 + mysql 5)

No updates?

Sorry I am swamped with work at the moment and other important projects, I couldnt look into it yet.

Commenting the if this part:

            // don't do this for an empty id array
            //if (count($ids) > 0) {
                $namespace = WhereInWalker::PAGINATOR_ID_ALIAS;

                $whereInQuery->setHint(Query::HINT_CUSTOM_TREE_WALKERS, array('Doctrine\ORM\Tools\Pagination\WhereInWalker'));
                $whereInQuery->setHint(WhereInWalker::HINT_PAGINATOR_ID_COUNT, count($ids));
                $whereInQuery->setFirstResult(null)->setMaxResults(null);
                foreach ($ids as $i => $id) {
                    $i++;
                    $whereInQuery->setParameter("{$namespace}_{$i}", $id);
                }
            //}

make it works, for me is better, because if you don't have results to show as the result of the select distinct is empty you shouldn't have any result at all. Because if you don't add the "WHERE IN" query you get the results joined with no difference between using or not the paginator.

This is weird, an empty IN() normally produces an error. We could add a non matching condition instead, like 0 = 1.

Not really, in my case (mysql) it creates the following query:

SELECT i0_.id AS id0, i0_.name AS name1, i0_.status AS status2, i0_.last_processing AS last_processing3, i0_.creation_time AS creation_time4, i0_.height AS height5, i0_.width AS width6, i0_.layers AS layers7, i0_.foldersize AS foldersize8, i0_.sourcesize AS sourcesize9, i0_.title AS title10, i0_.description AS description11, i0_.originalUrl AS originalUrl12, i0_.private AS private13, i0_.watermark AS watermark14, i0_.favorite AS favorite15, t1_.id AS id16, t1_.tag AS tag17, i0_.owner AS owner18, t1_.image AS image19 FROM Image i0_ LEFT JOIN Tag t1_ ON i0_.id = t1_.image WHERE i0_.owner = 1 AND i0_.id IS NULL ORDER BY i0_.creation_time DESC

so it sets "AND i0_.id IS NULL" which solves the problem, the best solution for me is to directly return an empty set if the DISTINCT gives no results.

Solved with commit bc2476f342ceda98559b87a314806581cf969796

Existing PR at https://github.com/doctrine/doctrine2/pull/361

Merged: https://github.com/doctrine/doctrine2/commit/1b2b831febb780d8153bc4f8684baa763dd8f177

Assigned to asm

This issue is referenced in Github Pull-Request GH-226
https://github.com/doctrine/doctrine2/pull/226

Should be fixed as soon as this is pulled:
https://github.com/doctrine/doctrine2/pull/226

Related Pull Request was closed: https://github.com/doctrine/doctrine2/pull/226

This is a duplicate of a previous issue and is fixed in master.

Mac, MySQL, PHP 5.3.3

Now i get it. This is not a bug.

You cannot mix mappings from annotations and xml to define a single entity mapping. Its not possible.

One Solution would be to add annotations to the User bae class. That would have to be on the DoctrineUserBundle then.

Ok ! Thanks but one thing is that the creator of this bundle (ornicar) has created a website called lichess.org and use DoctrineUserBundle.

In this app, he created a User.php sub classing the Base User of DoctrineUserBundle and he used annotations but with mongodb

https://github.com/ornicar/lichess/blob/master/src/Application/DoctrineUserBundle/Document/User.php

How it's possible that it works with ODM and not with ORM ?

THanks a lot for your time

Hm maybe its a bug with mapped superclasses. I thought Ornicar did a little hack there regarding mixing.

But in general ORM != ODM.

That bug happens when the Doctrine UserBundle is not detected correctly.

It should be fixed with the current Symfony2 state of code.

So now we are able to mix mappings or something else was fixed.

Because right now I'm getting the same error using latest symfony-sandbox code.

read the master docs of symfony2 please, there was a change in configuration:

http://docs.symfony-reloaded.org/master/guides/doctrine/orm/overview.html