Doctrine PHPCR
  1. Doctrine PHPCR
  2. PHPCR-65

find with uuid creates duplicate of document

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Labels:
      None

      Description

      i am pretty sure the DocumentManager::find() method creates a duplicate document each time you request the document by uuid. it should not just load the node but convert that node to a path and then do the check if the document is cached. if the node is already cached the lookup by uuid is cheap. if not, it is now cached and the lookup by path is cheap. so no overhead, but eliminate the risk of having several instances of the same document.

      https://github.com/doctrine/phpcr-odm/blob/master/lib/Doctrine/ODM/PHPCR/DocumentManager.php#L279

        Activity

        Hide
        David Buchmann added a comment -

        thanks, looks good to me now.

        Show
        David Buchmann added a comment - thanks, looks good to me now.
        Show
        Lukas Kahwe added a comment - this issue seems to be fixed https://github.com/doctrine/phpcr-odm/blob/master/lib/Doctrine/ODM/PHPCR/DocumentManager.php#L289

          People

          • Assignee:
            Lukas Kahwe
            Reporter:
            David Buchmann
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: