Doctrine PHPCR
  1. Doctrine PHPCR
  2. PHPCR-60

add finalize step to mapping to calculate and validate

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Labels:
      None

      Description

      follow up of the discussion in https://github.com/doctrine/phpcr-odm/pull/120

      id strategy:

      1. if there is an id with a strategy always use that
      2. if not and there is a parent and a node name mapping use the parent strategy
      3. else use assigned strategy if there is an id field
      4. throw an exception that you can't use this document

      finalizing the mapping could have the added benefit of combined validation. for example if assigned strategy is parent and name but there is no field mapped to the name, it would tell this is invalid.

      think what should be validated at the finalize point.

        Activity

        David Buchmann created issue -
        Hide
        Lukas Kahwe added a comment -

        added a method for final validation here https://github.com/doctrine/phpcr-odm/pull/180

        Show
        Lukas Kahwe added a comment - added a method for final validation here https://github.com/doctrine/phpcr-odm/pull/180
        Show
        David Buchmann added a comment - see https://github.com/doctrine/phpcr-odm/pull/351
        David Buchmann made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]

        This list may be incomplete, as errors occurred whilst retrieving source from linked applications:

        • Request to http://www.doctrine-project.org/fisheye/ failed: Error in remote call to 'FishEye 0 (http://www.doctrine-project.org/fisheye/)' (http://www.doctrine-project.org/fisheye) [AbstractRestCommand{path='/rest-service-fe/search-v1/crossRepositoryQuery', params={query=PHPCR-60, expand=changesets[0:20].revisions[0:29],reviews}, methodType=GET}] : Received status code 503 (Service Temporarily Unavailable)

          People

          • Assignee:
            Lukas Kahwe
            Reporter:
            David Buchmann
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: