Uploaded image for project: 'Doctrine PHPCR'
  1. Doctrine PHPCR
  2. PHPCR-105

ensure xml and yml naming conventions are consistent

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Labels:
      None

      Description

      for yml, all mappings must use camelCase, while for xml it must be connected-text in all lowercase with the dash between. it seems at least fieldName is wrong.

      we should clean this up before the first release to avoid having to deal with inconsistent legacy from the beginning.

        Activity

        Hide
        dbu David Buchmann added a comment -
        Show
        dbu David Buchmann added a comment - for xml, see this PR https://github.com/doctrine/phpcr-odm/pull/279
        Hide
        dbu David Buchmann added a comment -

        yml is using camelCase everywhere. should we rename fieldName to name as well or is that fine here?

        Show
        dbu David Buchmann added a comment - yml is using camelCase everywhere. should we rename fieldName to name as well or is that fine here?

          People

          • Assignee:
            lsmith Lukas Kahwe
            Reporter:
            dbu David Buchmann
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: