Doctrine 2 - ORM

[GH-484] Prevented "Undefined index" notice when updating

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Trivial Trivial
  • Resolution: Fixed
  • Affects Version/s: 2.3, Git Master
  • Fix Version/s: 2.3.1
  • Component/s: ORM
  • Security Level: All
  • Labels:
  • Environment:
    OS X 10.8.2, PHP 5.3.17, Nginx 1.2.4 (php through FPM)

Description

This issue is created automatically through a Github pull request on behalf of jappie:

Url: https://github.com/doctrine/doctrine2/pull/484

Message:

While executing updates on an entity scheduled for update without a change-set, an "Undefined index" notice is raised.

This issue will occur when you manually call $em()->getUnitOfWork()->scheduleForUpdate() on an entity that hasn't changed. The entity will be included in UnitOfWork::$entityUpdates, but because there are no changes, its oid will not be included in UnitOfWork::$entityChangeSets.

I know I'm misusing scheduleForUpdate() a bit in this case, but the notice can easily be prevented with a !empty().

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Benjamin Eberlei added a comment -

A related Github Pull-Request [GH-484] was closed
https://github.com/doctrine/doctrine2/pull/484

Show
Benjamin Eberlei added a comment - A related Github Pull-Request [GH-484] was closed https://github.com/doctrine/doctrine2/pull/484
Hide
Permalink
Fabio B. Silva added a comment -

Merged : https://github.com/doctrine/doctrine2/commit/cd7ef6e7a70d4ff4c25a85fdae71676aa6548ea6

Show
Fabio B. Silva added a comment - Merged : https://github.com/doctrine/doctrine2/commit/cd7ef6e7a70d4ff4c25a85fdae71676aa6548ea6

People

  • Assignee:
    Benjamin Eberlei
    Reporter:
    Benjamin Eberlei
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: