Doctrine 2 - ORM
  1. Doctrine 2 - ORM
  2. DDC-2082

[GH-481] check for false as a return value from get_parent_class(), not null

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.3.1
    • Component/s: None
    • Security Level: All
    • Labels:
      None

      Description

      This issue is created automatically through a Github pull request on behalf of beejeebus:

      Url: https://github.com/doctrine/doctrine2/pull/481

      Message:

      MappingException::identifierRequired() and MappingException::classIsNotAValidEntityOrMappedSuperClass() both check for null, when they should check for false from get_parent_class().

        Activity

        Hide
        Doctrine Bot added a comment -

        A related Github Pull-Request [GH-481] was closed:
        https://github.com/doctrine/dbal/pull/481

        Show
        Doctrine Bot added a comment - A related Github Pull-Request [GH-481] was closed: https://github.com/doctrine/dbal/pull/481
        Show
        Fabio B. Silva added a comment - Merged : https://github.com/doctrine/doctrine2/commit/9d0b254407e6f8827e0f00aa4ed0fcefc6111aad
        Hide
        Benjamin Eberlei added a comment -

        A related Github Pull-Request [GH-481] was closed
        https://github.com/doctrine/doctrine2/pull/481

        Show
        Benjamin Eberlei added a comment - A related Github Pull-Request [GH-481] was closed https://github.com/doctrine/doctrine2/pull/481

          People

          • Assignee:
            Benjamin Eberlei
            Reporter:
            Benjamin Eberlei
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: