Doctrine 2 - ORM
  1. Doctrine 2 - ORM
  2. DDC-1852

Doctrine\ORM\Tools\SchemaValidator should check validity of lifecycle callbacks

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: Git Master
    • Fix Version/s: 2.x, 2.5
    • Component/s: ORM
    • Security Level: All
    • Labels:
      None

      Description

      The schema validator should analyze mapped lifecycle callbacks and:

      a) if some lifecycle callbacks were defined, but no @HasLifecycleCallbacks annotation/mapping was set, warn the user
      b) if some lifecycle callbacks were defined, but methods are not public, warn the user

        Activity

        Marco Pivetta created issue -
        Hide
        Marco Pivetta added a comment -
        Show
        Marco Pivetta added a comment - Existing PR at https://github.com/doctrine/doctrine2/pull/361
        Benjamin Eberlei made changes -
        Field Original Value New Value
        Workflow jira [ 13752 ] jira-feedback [ 14074 ]
        Benjamin Eberlei made changes -
        Workflow jira-feedback [ 14074 ] jira-feedback2 [ 15938 ]
        Benjamin Eberlei made changes -
        Workflow jira-feedback2 [ 15938 ] jira-feedback3 [ 18187 ]
        Benjamin Eberlei made changes -
        Fix Version/s 2.4 [ 10321 ]
        Fix Version/s 2.3 [ 10185 ]
        Benjamin Eberlei made changes -
        Fix Version/s 2.5 [ 10522 ]
        Fix Version/s 2.4 [ 10321 ]
        Guilherme Blanco made changes -
        Fix Version/s Git Master [ 10100 ]

        This list may be incomplete, as errors occurred whilst retrieving source from linked applications:

        • Request to http://www.doctrine-project.org/fisheye/ failed: Error in remote call to 'FishEye 0 (http://www.doctrine-project.org/fisheye/)' (http://www.doctrine-project.org/fisheye) [AbstractRestCommand{path='/rest-service-fe/search-v1/crossRepositoryQuery', params={query=DDC-1852, expand=changesets[0:20].revisions[0:29],reviews}, methodType=GET}] : Received status code 503 (Service Temporarily Unavailable)

          People

          • Assignee:
            Benjamin Eberlei
            Reporter:
            Marco Pivetta
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated: