Doctrine DBAL

Custom commented column type removal causes unknown column type exception

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 2.2.1
  • Fix Version/s: None
  • Component/s: Schema Managers
  • Security Level: All
  • Labels:
    None

Description

Problem happens when initially, as example, there was commented type "foo" registered and used:

Doctrine\DBAL\Types\Type::addType('foo', 'FooType');
$em->getConnection()
    ->getDatabasePlatform()
    ->markDoctrineTypeCommented(Doctrine\DBAL\Types\Type::getType('foo'));

When the type usage and declaration is removed, the database schema upgrade fails.
This is because DBAL reads the comment from the database and tries to find the type 'foo'.

I suggest ignoring the database column comment and stick to the standard type recognition in case the type is not declared.

Activity

Hide
Permalink
Aigars Gedroics added a comment -

Trivial solution would be:

--- a/Doctrine/DBAL/Schema/AbstractSchemaManager.php
+++ b/Doctrine/DBAL/Schema/AbstractSchemaManager.php
@@ -878,7 +878,9 @@ abstract class AbstractSchemaManager
     public function extractDoctrineTypeFromComment($comment, $currentType)
     {
         if (preg_match("(\(DC2Type:([a-zA-Z0-9]+)\))", $comment, $match)) {
-            $currentType = $match[1];
+                       if (Types\Type::hasType($match[1])) {
+                               $currentType = $match[1];
+                       }
         }
         return $currentType;
     }
Show
Aigars Gedroics added a comment - Trivial solution would be: --- a/Doctrine/DBAL/Schema/AbstractSchemaManager.php +++ b/Doctrine/DBAL/Schema/AbstractSchemaManager.php @@ -878,7 +878,9 @@ abstract class AbstractSchemaManager public function extractDoctrineTypeFromComment($comment, $currentType) { if (preg_match( "(\(DC2Type:([a-zA-Z0-9]+)\))" , $comment, $match)) { - $currentType = $match[1]; + if (Types\Type::hasType($match[1])) { + $currentType = $match[1]; + } } return $currentType; }

People

  • Assignee:
    Benjamin Eberlei
    Reporter:
    Aigars Gedroics
Vote (0)
Watch (1)

Dates

  • Created:
    Updated: